Playground: Refactor messages types and parsing (string enums, readonly)#35482
Open
monokkai wants to merge 1 commit intofacebook:mainfrom
Open
Playground: Refactor messages types and parsing (string enums, readonly)#35482monokkai wants to merge 1 commit intofacebook:mainfrom
monokkai wants to merge 1 commit intofacebook:mainfrom
Conversation
…ly, normalize parsing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playground: Refactor message types and parsing for stronger typing and robustness
Convert numeric enums to string enums to make runtime values explicit.
Make Message fields readonly and codeframe optional to express data intent.
Normalize message parsing to handle CRLF and trailing whitespace and to treat empty bodies as no codeframe
Confine changes to the playground to reduce risk to core packages.
How did you test this change?
Manual smoke test (playground UI): start the playground and exercise message flows:
Send a single-line message → expect title populated and no codeframe
Send a multi-line message with trailing spaces → expect title to be first line (trimmed) and codeframe to contain trimmed remaining lines.
Send a CRLF message (\r\n) → expect codeframe normalized to LF (\n).
Verify UI: icon matches level, codeframe displays in the message body when present, and dismiss button behavior (non-Playground sources dismissible) remains unchanged.